Skip to content

Fixed bug for LilyGo T-display on boards.txt #8744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fixed bug for LilyGo T-display on boards.txt #8744

merged 2 commits into from
Oct 11, 2023

Conversation

thebear132
Copy link
Contributor

Fixed bug by adding upload.flags and upload.extra_flags to LilyGo T-display

Fixed same issue as #5589

@thebear132
Fixed bug for LilyGo T-display
ba9c15e 
Fixed bug by adding upload.flags and upload.extra_flags to LilyGo T-display
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thebear132 Thanks for fixing that.

@P-R-O-C-H-Y P-R-O-C-H-Y added Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. Status: Pending Merge Pull Request is ready to be merged labels Oct 9, 2023
@thebear132
Copy link
Contributor Author

Hmm, i just clicked "Update branch", as it said it was behind main. Maybe i shouldnt have done that?

@P-R-O-C-H-Y
Copy link
Member

@thebear132 Its ok :) We always need this to be done before merging it.

@me-no-dev me-no-dev merged commit c2db50a into espressif:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebear132 @CLAassistant @P-R-O-C-H-Y @me-no-dev